unboundsoftware/storage
6
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 10 Activity

feat: add PresignInlineURL method for inline content display #97

Merged
argoyle merged 1 commits from feat-presign-inline into main 2026-04-16 08:52:40 +00:00
Conversation 0 Commits 1 Files Changed 1
+19
argoyle commented 2026-04-16 08:45:50 +00:00
Owner
Copy Link
Copy Source

Summary

  • Add PresignInlineURL(ctx, key, contentType) method that generates presigned URLs with Content-Disposition: inline and optional Content-Type override
  • Browsers will render content (e.g. PDFs) directly in iframes instead of triggering download dialogs
  • Existing PresignURL remains unchanged

Context

The document-service uses presigned S3 URLs to display PDFs in iframes. Without Content-Disposition: inline, the browser triggers a download dialog instead of rendering the PDF.

🤖 Generated with Claude Code

## Summary - Add `PresignInlineURL(ctx, key, contentType)` method that generates presigned URLs with `Content-Disposition: inline` and optional `Content-Type` override - Browsers will render content (e.g. PDFs) directly in iframes instead of triggering download dialogs - Existing `PresignURL` remains unchanged ## Context The document-service uses presigned S3 URLs to display PDFs in iframes. Without `Content-Disposition: inline`, the browser triggers a download dialog instead of rendering the PDF. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
argoyle added 1 commit 2026-04-16 08:45:51 +00:00
feat: add PresignInlineURL method for inline content display
storage / test (pull_request) Successful in 1m41s
Details
storage / vulnerabilities (pull_request) Successful in 1m46s
Details
pre-commit / pre-commit (pull_request) Successful in 6m10s
Details
4199fc84e7 
Generates presigned URLs with Content-Disposition: inline and optional
Content-Type override, so browsers render content (e.g. PDFs) directly
instead of triggering a download dialog.
argoyle scheduled this pull request to auto merge when all checks succeed 2026-04-16 08:46:15 +00:00
argoyle merged commit 862ec3f7bc into main 2026-04-16 08:52:40 +00:00
argoyle deleted branch feat-presign-inline 2026-04-16 08:52:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acctest (Shiny Acctest) argoyle (Joakim Olsson) buildtools (Buildtools) kubernetes (Kubernetes) releaser (Unbound Releaser) renovate (Renovate Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: unboundsoftware/storage#97
Delete Branch "feat-presign-inline"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?