Two transports (GRAPHQL and UrlEncodedForm) did not have return
statement at the end of if err block. Instead of returning
a 'could not cleanup body' error, we continued processing.
User still got an error. But instead of early 'could not cleanup'
error, user gor 'Internal system error' which happened a few
lines after the if block.
Tests are added.
a13eca12 update autogenerated gqlgen.yml with new options. (#2622)
Dependabot commands
You can trigger Dependabot actions by commenting on this MR
$dependabot rebase will rebase this MR
$dependabot recreate will recreate this MR rewriting all the manual changes and resolving conflicts
Bumps [github.com/99designs/gqlgen](https://github.com/99designs/gqlgen) from 0.17.30 to 0.17.31.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/99designs/gqlgen/releases">github.com/99designs/gqlgen's releases</a>.</em></p>
<blockquote>
<h2>v0.17.31</h2>
<h2>What's Changed</h2>
<ul>
<li>update autogenerated gqlgen.yml with new options by <a href="https://github.com/fiatjaf"><code>@fiatjaf</code></a> in <a href="https://github.com/99designs/gqlgen/pull/2622">99designs/gqlgen#2622</a></li>
<li>Bugfix: add missing return statements in GRAPHQL and UrlEncodedForm t… by <a href="https://github.com/RatkoR"><code>@RatkoR</code></a> in <a href="https://github.com/99designs/gqlgen/pull/2625">99designs/gqlgen#2625</a></li>
<li>Omittable input fields by <a href="https://github.com/Desuuuu"><code>@Desuuuu</code></a> in <a href="https://github.com/99designs/gqlgen/pull/2585">99designs/gqlgen#2585</a></li>
<li>New option to make comments on resolver optional by <a href="https://github.com/mokeko"><code>@mokeko</code></a> in <a href="https://github.com/99designs/gqlgen/pull/2627">99designs/gqlgen#2627</a></li>
<li>fix: allow space in go tag value by <a href="https://github.com/gitxiongpan"><code>@gitxiongpan</code></a> in <a href="https://github.com/99designs/gqlgen/pull/2628">99designs/gqlgen#2628</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/fiatjaf"><code>@fiatjaf</code></a> made their first contribution in <a href="https://github.com/99designs/gqlgen/pull/2622">99designs/gqlgen#2622</a></li>
<li><a href="https://github.com/mokeko"><code>@mokeko</code></a> made their first contribution in <a href="https://github.com/99designs/gqlgen/pull/2627">99designs/gqlgen#2627</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/99designs/gqlgen/compare/v0.17.30...v0.17.31">https://github.com/99designs/gqlgen/compare/v0.17.30...v0.17.31</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/99designs/gqlgen/blob/master/CHANGELOG.md">github.com/99designs/gqlgen's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/99designs/gqlgen/compare/v0.17.30...v0.17.31">v0.17.31</a> - 2023-05-05</h2>
<ul>
<li>
<p><!-- raw HTML omitted --><!-- raw HTML omitted -->37b26207<!-- raw HTML omitted --><!-- raw HTML omitted --> release v0.17.31</p>
</li>
<li>
<p><!-- raw HTML omitted --><!-- raw HTML omitted -->4016b2bd<!-- raw HTML omitted --><!-- raw HTML omitted --> fix (<!-- raw HTML omitted --><a href="https://github.com/99designs/gqlgen/issues/2628">#2628</a><!-- raw HTML omitted -->)</p>
</li>
<li>
<p><!-- raw HTML omitted --><!-- raw HTML omitted -->5a81c3e3<!-- raw HTML omitted --><!-- raw HTML omitted --> Remove other &&</p>
</li>
<li>
<p><!-- raw HTML omitted --><!-- raw HTML omitted -->fde269c0<!-- raw HTML omitted --><!-- raw HTML omitted --> Remove extraneous run</p>
</li>
<li>
<p><!-- raw HTML omitted --><!-- raw HTML omitted -->47a5b333<!-- raw HTML omitted --><!-- raw HTML omitted --> Avoid && in command for retry</p>
</li>
<li>
<p><!-- raw HTML omitted --><!-- raw HTML omitted -->4d8f850b<!-- raw HTML omitted --><!-- raw HTML omitted --> Add timeout minutes</p>
</li>
<li>
<p><!-- raw HTML omitted --><!-- raw HTML omitted -->c839b6c1<!-- raw HTML omitted --><!-- raw HTML omitted --> Bandaid for flaky websocket tests</p>
</li>
</ul>
<!-- raw HTML omitted -->
<ul>
<li>
<p>remove 'foo' above resolver</p>
</li>
<li>
<p>regenerate after 6a3869707da1ffff7c196fcbcac44c92</p>
</li>
<li>
<p>omit resolver template comment</p>
</li>
<li>
<p>re-generate</p>
</li>
</ul>
<!-- raw HTML omitted -->
<ul>
<li><!-- raw HTML omitted --><!-- raw HTML omitted -->239b97ee<!-- raw HTML omitted --><!-- raw HTML omitted --> Omittable input fields (<!-- raw HTML omitted --><a href="https://github.com/99designs/gqlgen/issues/2585">#2585</a><!-- raw HTML omitted -->)</li>
</ul>
<!-- raw HTML omitted -->
<p>Two transports (GRAPHQL and UrlEncodedForm) did not have return
statement at the end of <code>if err</code> block. Instead of returning
a 'could not cleanup body' error, we continued processing.</p>
<p>User still got an error. But instead of early 'could not cleanup'
error, user gor 'Internal system error' which happened a few
lines after the if block.</p>
<p>Tests are added.</p>
<!-- raw HTML omitted -->
<ul>
<li>
<p><!-- raw HTML omitted --><!-- raw HTML omitted -->a13eca12<!-- raw HTML omitted --><!-- raw HTML omitted --> update autogenerated gqlgen.yml with new options. (<!-- raw HTML omitted --><a href="https://github.com/99designs/gqlgen/issues/2622">#2622</a><!-- raw HTML omitted -->)</p>
</li>
<li>
<p><!-- raw HTML omitted --><!-- raw HTML omitted -->f1f63b52<!-- raw HTML omitted --><!-- raw HTML omitted --> Post Release Changelog entry</p>
</li>
<li>
<p><!-- raw HTML omitted --><!-- raw HTML omitted -->81f3469f<!-- raw HTML omitted --><!-- raw HTML omitted --> v0.17.30 postrelease bump</p>
</li>
</ul>
<!-- raw HTML omitted -->
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/99designs/gqlgen/commit/37b262075d385c49505ba76e09aec520f23f70f0"><code>37b2620</code></a> release v0.17.31</li>
<li><a href="https://github.com/99designs/gqlgen/commit/4016b2bde056a9c83b21e1e84cde1319bd8461a8"><code>4016b2b</code></a> fix (<a href="https://github.com/99designs/gqlgen/issues/2628">#2628</a>)</li>
<li><a href="https://github.com/99designs/gqlgen/commit/5a81c3e37ae8caab333476e5917613f6d580083b"><code>5a81c3e</code></a> Remove other &&</li>
<li><a href="https://github.com/99designs/gqlgen/commit/fde269c0b7130e89104c37b2ee5bc6f8704d788f"><code>fde269c</code></a> Remove extraneous run</li>
<li><a href="https://github.com/99designs/gqlgen/commit/47a5b33360aec66c59c0af55fe152bfac8170434"><code>47a5b33</code></a> Avoid && in command for retry</li>
<li><a href="https://github.com/99designs/gqlgen/commit/4d8f850b51dade590a8672a2b938b486339c74fe"><code>4d8f850</code></a> Add timeout minutes</li>
<li><a href="https://github.com/99designs/gqlgen/commit/c839b6c1d846b4bfac7f7e80c4ef9f9293d40413"><code>c839b6c</code></a> Bandaid for flaky websocket tests</li>
<li><a href="https://github.com/99designs/gqlgen/commit/395c362b50f2e97207e8c5c37b8413748dc4b05f"><code>395c362</code></a> New option to make comments on resolver optional (<a href="https://github.com/99designs/gqlgen/issues/2627">#2627</a>)</li>
<li><a href="https://github.com/99designs/gqlgen/commit/239b97ee7578dc59d3d35421d8c4fd65f2506193"><code>239b97e</code></a> Omittable input fields (<a href="https://github.com/99designs/gqlgen/issues/2585">#2585</a>)</li>
<li><a href="https://github.com/99designs/gqlgen/commit/2ad08ffffe7b2b3269b04a71808b15abb4dda7c1"><code>2ad08ff</code></a> Bugfix: add missing return statements in GRAPHQL and UrlEncodedForm transport...</li>
<li>Additional commits viewable in <a href="https://github.com/99designs/gqlgen/compare/v0.17.30...v0.17.31">compare view</a></li>
</ul>
</details>
<br />
---
<details>
<summary>Dependabot commands</summary>
<br />
You can trigger Dependabot actions by commenting on this MR
- `$dependabot rebase` will rebase this MR
- `$dependabot recreate` will recreate this MR rewriting all the manual changes and resolving conflicts
</details>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Bumps github.com/99designs/gqlgen from 0.17.30 to 0.17.31.
Release notes
Sourced from github.com/99designs/gqlgen's releases.
Changelog
Sourced from github.com/99designs/gqlgen's changelog.
... (truncated)
Commits
37b2620release v0.17.314016b2bfix (#2628)5a81c3eRemove other &&fde269cRemove extraneous run47a5b33Avoid && in command for retry4d8f850Add timeout minutesc839b6cBandaid for flaky websocket tests395c362New option to make comments on resolver optional (#2627)239b97eOmittable input fields (#2585)2ad08ffBugfix: add missing return statements in GRAPHQL and UrlEncodedForm transport...Dependabot commands
You can trigger Dependabot actions by commenting on this MR
$dependabot rebasewill rebase this MR$dependabot recreatewill recreate this MR rewriting all the manual changes and resolving conflictsadded 2 commits
64be912d- 1 commit from branchmainbd70eac1- chore(deps): bump github.com/99designs/gqlgen from 0.17.30 to 0.17.31Compare with previous version