multi-architecture-dockerfile-updates #228

2026-01-19T07:28:53Z

peter commented

2026-01-19 07:28:53 +00:00

Add ARG directives for TARGETOS and TARGETARCH to enable multi-architecture support.
Modify the build command to use the specified target OS and architecture for more flexible and portable builds.
Ensure compatibility with different deployment environments

Add ARG directives for TARGETOS and TARGETARCH to enable multi-architecture support. Modify the build command to use the specified target OS and architecture for more flexible and portable builds. Ensure compatibility with different deployment environments

argoyle requested changes 2026-01-19 07:30:46 +00:00

Dismissed

Dockerfile Outdated

						
				@@ -15,3 +18,3 @@

				RUN go tool cover -func=coverage.txt

				RUN rm coverage.txt.tmp

				RUN GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -mod=readonly -o release/default-request-adder -ldflags '-w -s'

				RUN iGOOS=${TARGETOS} GOARCH=${TARGETARCH} CGO_ENABLED=0 go build -mod=readonly -o release/default-request-adder -ldflags '-w -s'

argoyle commented

2026-01-19 07:30:40 +00:00

The initial i looks like a typo?

The initial `i` looks like a typo?

peter marked this conversation as resolved

peter force-pushed multi-architecture-dockerfile-updates from 1112550f30 to 9a089c8af7

2026-01-19 07:32:06 +00:00

Compare

argoyle approved these changes 2026-01-19 07:34:25 +00:00

argoyle manually merged commit 24ed80e146 into main

2026-01-19 10:09:44 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unboundsoftware/default-request-adder#228