shiny/otelsetup
6
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 26 Activity

feat(metrics): add SubscriptionMetrics OTel observer for subscriptions #150

Merged
argoyle merged 1 commits from feat/subscription-metrics into main 2026-06-16 13:14:16 +00:00
Conversation 1 Commits 1 Files Changed 2
+193
1 Commits
Author SHA1 Message Date
argoyleandClaude Opus 4.8 cb99bbc1a6 feat(metrics): add SubscriptionMetrics OTel observer for read-your-writes subscriptions
otelsetup / vulnerabilities (pull_request) Successful in 1m39s
Details
otelsetup / test (pull_request) Successful in 2m42s
Details
pre-commit / pre-commit (pull_request) Successful in 5m33s
Details 
NewSubscriptionMetrics(subscription) returns a *SubscriptionMetrics whose method
set (Pushed/PushSkipped/Dropped/ChannelFull) satisfies the Observer interface of
gitea.unbound.se/shiny/subscriptions structurally — otelsetup does not import
that library. Services wire it via subscriptions.WithObserver so the
cross-service subscription push path (ADR-0012) reports outcomes as metrics
instead of only the library's skip/drop warn logs.

One Int64Counter `subscription.notifications` labelled by (subscription, outcome)
only — the subscriber key (company id / user email) is deliberately NOT a label
to avoid unbounded cardinality. skip-rate = skipped/(pushed+skipped).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-16 15:07:35 +02:00