feat: add gqlgen Recover that logs panics as one structured record (#206)
otelsetup / test (push) Successful in 43s
otelsetup / vulnerabilities (push) Successful in 44s
Unbound Release / Check Preconditions (push) Successful in 1s
Unbound Release / Create Tag (push) Skipped
Unbound Release / Create Release (push) Successful in 4s
Unbound Release / Generate Changelog and Handle PR (push) Successful in 9s
Release / release (push) Successful in 14s
pre-commit / pre-commit (push) Successful in 2m25s
otelsetup / test (push) Successful in 43s
otelsetup / vulnerabilities (push) Successful in 44s
Unbound Release / Check Preconditions (push) Successful in 1s
Unbound Release / Create Tag (push) Skipped
Unbound Release / Create Release (push) Successful in 4s
Unbound Release / Generate Changelog and Handle PR (push) Successful in 9s
Release / release (push) Successful in 14s
pre-commit / pre-commit (push) Successful in 2m25s
## Summary gqlgen's `graphql.DefaultRecover` prints a recovered resolver panic and `debug.PrintStack()` to stderr, so the log collector stores every stack line as a separate, level-less entry (~60 entries per panic in production). Adds `otelsetup.Recover` (`func(ctx context.Context, err any) error`, a `graphql.RecoverFunc` for gqlgen v0.17.95): - logs the panic as **one** ERROR record via `slog.Default().ErrorContext` (the default logger services set up through `logging.SetupLogger`), with `panic`, `stack` (`debug.Stack()`) and `path` (GraphQL field path, when available) attributes - records the error on the active span (`RecordError` with stack trace, `SetStatus(codes.Error)`) - returns the generic `internal system error` gqlerror to the client, without the panic text Services install it with `srv.SetRecoverFunc(otelsetup.Recover)`. ## Test plan - `TestRecover`: error and non-error panic values; asserts the generic gqlerror, no panic text leak, exactly one ERROR log record with panic/stack attributes, and span status Error with an `exception` event carrying message and stacktrace (in-memory `tracetest.SpanRecorder`) - `go test -race ./...` passes, `prek run --all-files` passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01H6eVuR4Yt3m7TbDTDwyZJi Reviewed-on: #206
This commit was merged in pull request #206.
This commit is contained in:
1 parent
9fe1a21c02
commit
17130005c9
4 files changed
+167
-1
No files matched your search
@@ -28,6 +28,12 @@ defer shutdown(ctx)
|
||||
|
||||
// Wrap HTTP handlers with tracing
|
||||
http.Handle("/", otelsetup.Handler(myHandler))
|
||||
|
||||
// gqlgen server hooks
|
||||
srv.AroundOperations(otelsetup.AroundOperations)
|
||||
srv.AroundRootFields(otelsetup.AroundRootFields)
|
||||
srv.AroundFields(otelsetup.AroundFields)
|
||||
srv.SetRecoverFunc(otelsetup.Recover)
|
||||
```
|
||||
|
||||
### Features
|
||||
@@ -37,6 +43,8 @@ http.Handle("/", otelsetup.Handler(myHandler))
|
||||
- **Logging** - Stdout log exporter
|
||||
- **Propagation** - TraceContext and Baggage propagation
|
||||
- **HTTP Handler** - Middleware for automatic span creation
|
||||
- **gqlgen hooks** - Spans per operation, root field and resolver field
|
||||
- **gqlgen recover** - `Recover` logs a resolver panic as one ERROR record via `slog.Default()` (attributes `panic`, `stack`, `path`), records it on the active span with status Error, and returns the generic "internal system error" to the client (gqlgen's default prints the stack to stderr line by line)
|
||||
|
||||
### Environment Variables
|
||||
|
||||
|
||||
Reference in new issue
Block a user