feat: move MockLogger into a logtest sub-package #5

2026-06-19T16:37:23Z

argoyle commented

2026-06-19 16:37:23 +00:00

019ecc67 — logtest sub-package

NewMockLogger/MockLogger move from the main logging package to a new same-module logging/logtest sub-package (mirroring the existing middleware/ convention), so the production logging package's import graph is testify-free (go list -deps . → 0). testify stays in the module's go.mod because logtest and the library's own _test.go files use it — consumers only compile it if they import logtest.

Breaking import change

logging.NewMockLogger → logtest.NewMockLogger. All call sites in the ~12 backend services are in _test.go files; they'll be swept (import swap + go.mod bump to this release) in follow-up PRs. feat: (no !) so the shared Release.yml cuts a minor v0.2.0 (v0.x breaking → minor), not v1.0.0.

Review

Go Backend Expert: clean, no Critical/High/Medium. Verified verbatim move, all packages test green under -race, root production graph testify-free, gofumpt/vet clean, go.mod unchanged (testify retained as a test dep). Same-module sub-package confirmed correct over a nested module.

🤖 Generated with Claude Code

## 019ecc67 — logtest sub-package `NewMockLogger`/`MockLogger` move from the main `logging` package to a new same-module `logging/logtest` sub-package (mirroring the existing `middleware/` convention), so the **production `logging` package's import graph is testify-free** (`go list -deps .` → 0). `testify` stays in the module's `go.mod` because `logtest` and the library's own `_test.go` files use it — consumers only compile it if they import `logtest`. ### Breaking import change `logging.NewMockLogger` → `logtest.NewMockLogger`. All call sites in the ~12 backend services are in `_test.go` files; they'll be swept (import swap + go.mod bump to this release) in follow-up PRs. `feat:` (no `!`) so the shared Release.yml cuts a minor **v0.2.0** (v0.x breaking → minor), not v1.0.0. ### Review Go Backend Expert: clean, no Critical/High/Medium. Verified verbatim move, all packages test green under -race, root production graph testify-free, gofumpt/vet clean, go.mod unchanged (testify retained as a test dep). Same-module sub-package confirmed correct over a nested module. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

argoyle added 1 commit 2026-06-19 16:37:24 +00:00

feat: move MockLogger into a logtest sub-package

logging / coverage-baseline (pull_request) Has been skipped

Details

logging / vulnerabilities (pull_request) Successful in 1m32s

Details

logging / test (pull_request) Successful in 2m48s

Details

pre-commit / pre-commit (pull_request) Successful in 5m27s

Details

a45c50ab7b

NewMockLogger/MockLogger move from the main `logging` package to a new
`logging/logtest` sub-package, so the production `logging` package's import
graph no longer pulls in testify — only consumers that import logtest do.
testify stays in the module's go.mod (used by logtest and the library's own
tests).

Breaking import change for consumers: `logging.NewMockLogger` becomes
`logtest.NewMockLogger`. The backend services that reference it are updated to
the logtest import alongside their go.mod bump to this release.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

argoyle scheduled this pull request to auto merge when all checks succeed 2026-06-19 16:37:26 +00:00

gitea-actions bot commented

2026-06-19 16:40:12 +00:00